-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Calendar #18
Google Calendar #18
Conversation
576317c
to
6357d3b
Compare
I think this is sufficient for an initial, useful implementation. (I'll add some notes regarding further work to issue #16.) |
6357d3b
to
95aed09
Compare
95aed09
to
0e4f459
Compare
0e4f459
to
a0328eb
Compare
<script type="text/x-red" data-template-name="google-credentials"> | ||
<div id="node-config-google-client-keys"> | ||
<div class="form-row"> | ||
<p style="margin-top: 10px;"><b>1.</b> Create your own project by following these <a href="https://developers.google.com/api-client-library/javascript/start/start-js#Getaccesskeysforyourapplication" target="_blank" style="text-decoration:underline;">instructions</a></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably add more information into the tooltip here to be honest. This is because there are several options available on the Google pages and therefore the user might need more guidance. I personally got confused. Just finding out as I write this why I got 401, invalid_client from Google!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like either the anchor is wrong or it has changed. It should be #Getkeysforyourapplication then I think the instructions are pretty clear?
I've now fixed the anchor. Thanks Zoltan. I'm curious to know if you still think the instructions are not clear.
261a4aa
to
f4b903c
Compare
f4b903c
to
10d8b57
Compare
Work in progress for a google calendar node. Several starting points for discussion:
I've missed something in search/replacing the flickr code so the 'displayName` doesn't seem to be used correctly. I can't see why.Fixed. Thanks to @hbeeken for spotting my mistake.Comments/thoughts welcome.